feat: Reorganise workflow yamls #262
Conversation
| @@ -80,10 +80,10 @@ def argument_parser(): | |||
| return parser | |||
|
|
|||
|
|
|||
| def main(): | |||
| """Updates connected_to_network and triggers Undersync. | |||
| main def(): | |||
There was a problem hiding this comment.
should be def main():?
There was a problem hiding this comment.
whoops, thanks fixed in rebase
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
1fb44e8
to
48ea845
Compare
The
I don't want to scope creep this, so happy to create separate JIRA for that if you think it's a good idea. |
There was a problem hiding this comment.
I think your current organization looks good overall, but I have a minor suggestion for improvement. The current naming convention is slightly misleading, as the 'workflows' folder implies that it contains Workflow objects, but it actually holds WorkflowTemplates. Would it be a good idea to rename the folder to workflowtemplates to better reflect its contents and avoid confusion?
Good point, I had mis-read the "kind" and I fixed this in 821457f |
|
I made some further changes, including the suggestions above but not the argo_utils changes. There are still a few paths to fix up. |
|
There's also apps/understack-workflows that would need to be moved back to here. |
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
2 times, most recently
from
cd9e986
to
f763e1e
Compare
We had a hierarchy of workflows that was not being fully utilised. This discards that structure in favour of the yaml file being organised by Kind and then by name. for i in `grep -lr "^kind: WorkflowTemplate"` ; do mv $i workflows/`cat "$i" | yq ".metadata.name"`.yaml done for i in `grep -lr "^kind: Sensor"` ; do mv $i sensors/`cat "$i" | yq ".metadata.name"`.yaml done etc
We don't use this structure any more.
These are separated out into folders by k8s namespace and then by "kind". Kustomization is added to manage these
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
f763e1e
to
327b223
Compare
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
557dd49
to
99ceecb
Compare
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
4 times, most recently
from
bf25e35
to
31a29e3
Compare
When CI runs on a fork it doesn't have permissions to push there
stevekeay
force-pushed
the
reorganise-workflow-yamls
branch
from
31a29e3
to
957b8a7
Compare
|
Closing in favour of #267 which has better CI |
This answers PUC-505
I don't know if this is the right layout, I was just trying to make the workflows consistent with one another.
I opened this as a starting point for a discussion. Needs further work before merging, to fix up paths, etc.
I left the
names alone, although there is probably room for improvement there.I also moved the
/argo-workflows/containersinto/containersand the existing contents of/containersshould move into subfolders like/containers/ironic/. I think there was originally good reason for the separation but they have become mixed up over time.