Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TlsTcpSpec for refreshing provider #2

Open
wants to merge 1 commit into
base: reloading-ssl-config
Choose a base branch
from

Conversation

raboof
Copy link
Owner

@raboof raboof commented May 28, 2020

This currently still gives a handshake error

ca-cert-file = ${getClass.getClassLoader.getResource("ssl/pem/certificate.pem").getPath}
ssl-context-cache-ttl = 1d

# TODO duplicated from config-ssl-engine - let's see if we can consolidate that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

protocol, enabled-algorithms and random-number-generator may be extracted and consolidated but not hostname-verification and require-mutual-authentication.

I think that's what you mentioned but wanted to disambiguate it. :-)

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I would like to also consolidate hostname-verification and require-mutual-authentication, but perhaps that's not feasible and indeed we won't. Let's see how far we can take this ;).

@ignasi35
Copy link

This currently still gives a handshake error

If the certificate you used (akka-remote/src/test/resources/ssl/pem/certificate.pem ) it the one that I think then I think the problem is that's a self-signed certificate.

In akka#29061 I had some handshake errors (bad_certificate or can't verify signature) when using the PEMs and certificates from akka-pki/test/resources. In akka@e5897b2 I added a handful of certs, and scripts to create them, that will pass the handshake and fix this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants