Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example with bare tls magic #3

Conversation

ignasi35
Copy link
Owner

Sample using AkkaTlsMagicSSLEngineProvider without any refactor.

This is to compare the original ConfigSSLEngineProdicer wth AkkaTlsMagicSSLEngineProvider. Here's a few details:

  • differences in settings (enable/disable hostname verification, enable/disable mTLS)
  • duplicate code

@ignasi35 ignasi35 changed the base branch from master to extract-key-and-trust-manager-creation May 27, 2020 20:04
@ignasi35
Copy link
Owner Author

@raboof I've simplified the code:

Then, I've extracted a few bits and pieces from AkkaTLSMagicSSLEngineProvider to separate classes.

Finally, I've introduced SSLEngineConfig (related to the discussion in raboof#2 (comment)) and used it in both AkkaTLSMagicSSLEngineProvider and the old ConfigSSLEngineProvider.

The most important detail on this last commit is that now there are only two EngineProvider implementations and only one of them support key rotation.

@ignasi35
Copy link
Owner Author

superseded by akka#29152

@ignasi35 ignasi35 closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant