Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox testing and coverage #107

Merged
merged 12 commits into from
Apr 6, 2022
Merged

Add tox testing and coverage #107

merged 12 commits into from
Apr 6, 2022

Conversation

quantumjot
Copy link
Owner

@quantumjot quantumjot commented Apr 6, 2022

  • add tox for testing on win, mac os and ubuntu for py 3.7-3.9
  • add codecov report
  • add badges to README

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@10d3a42). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             main    #107   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?      12           
  Lines           ?    1432           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?    1432           
  Partials        ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10d3a42...ccf3259. Read the comment docs.

@quantumjot quantumjot marked this pull request as ready for review April 6, 2022 09:44
Copy link
Collaborator

@paddyroddy paddyroddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some suggestions

tox.ini Outdated
platform =
macos: darwin
linux: linux
windows: win32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why test on Windows 32bit?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question! will change to windows -- this will prob be true for the other plugins too.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants