Tested on OS X, Linux and Win10, what about M1 mac?
#63
Labels
Comments
3 tasks
|
Reopening this as we still need a way to test of M1 mac |
|
This will be possible once we sort #235 as you can build on different architectures as well as OSs |
paddyroddy
added a commit
that referenced
this issue
Mar 22, 2023
…figs (#64) Fixes #63 - handle arbitrary user configs - when the plugin starts, the example `cell_config` and `particle_config` files are loaded, and users can load more of their own This ended up being a bigger refactor than I planned - I need to refactor quite a few of the functions because they assume there are two modes ('cell' and 'particle'). And at the same time I moved toward a more modular structure as has been suggested lowe-lab-ucl/napari-btrack#26. **refactor `napari_btrack.track` into various sub-packages and modules** - `napari_btrack.track`: - renamed to `napari_btrack.main` - contains only code for launching the plugin, defining callback functions, and running the analysis - `napari_btrack.config`: - a new module with classes to handle converting between scaled and unscaled matrices in `MotionModel`s - removed `Matrices` class (which hardcoded values for `cell` or `particle`modes) and replaced with `UnscaledTrackerConfig` to handle arbitrary user configs - `napari_btrack.widgets`: - a new sub-package for creating the widgets for the plugin - `napari_btrack.sync`: - a new module to handle updating a config from widget values or vice versa **other changes** - added per-file-ignores for some linting rules (allow `assert` in test files, allow unused imports in `__init__.py` files) - some classes / functions were being imported only for type checking - move these imports in a check `if TYPE_CHECKING:` so that they're not imported at runtime - renamed the function that launches the plugin from `napari_btrack.track.track` to `napari_btrack.main.create_btrack_widget` - explicitly set the expected `widget_type` when using `magicgui.widgets.create_widget` - knowing the widgets we're using should make it easier to move to using `qt` directly at some point, which would allow us to have separate tabs for each section - add tooltips for every widget - they're based on the `btrack` api docs --------- Co-authored-by: Patrick Roddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This will become a more common concern, but tested with Intel mac doesn't mean anything for M1 mac in my experience
The text was updated successfully, but these errors were encountered: