Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: make 7 number summary count base position starting from 1 #167

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

colinvwood
Copy link
Contributor

Addresses #110

There are no tests to update or add to, but I confirmed locally that this makes the desired change.

@colinvwood colinvwood self-assigned this Dec 13, 2024
@colinvwood colinvwood changed the title make 7 number summary count base position starting from 1 BUG: make 7 number summary count base position starting from 1 Dec 13, 2024
@colinvwood colinvwood linked an issue Dec 13, 2024 that may be closed by this pull request
Copy link
Member

@gregcaporaso gregcaporaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and this works for me. Thanks @colinvwood!

@gregcaporaso gregcaporaso merged commit 64ac759 into qiime2:dev Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Plot and 7-number summaries off-by-one
2 participants