Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot and 7-number summaries off-by-one #110

Open
thermokarst opened this issue Nov 12, 2019 · 1 comment · May be fixed by #167
Open

Plot and 7-number summaries off-by-one #110

thermokarst opened this issue Nov 12, 2019 · 1 comment · May be fixed by #167
Assignees
@colinvwood
Labels
good first issue Good for newcomers

Comments

@thermokarst
Copy link
Contributor

Bug Description
In the "Interactive Quality Plot" tab of the summarize viz, the index numbering scheme varies between the 7-number csv summary (0-start), and the D3 plot (1-start).

Steps to reproduce the behavior

  1. Go to https://view.qiime2.org/?src=https%3A%2F%2Fdocs.qiime2.org%2F2019.10%2Fdata%2Ftutorials%2Fmoving-pictures%2Fdemux.qzv

Expected behavior
The viz should utilize consistent indexing.

References

  1. Original forum post
@gregcaporaso
Copy link
Member

gregcaporaso commented Sep 19, 2023 •
edited
Loading

Confirmed that this is still an issue. We should adapt the csv file to start counting at 1.

@gregcaporaso gregcaporaso added the good first issue Good for newcomers label Sep 19, 2023
@github-project-automation github-project-automation bot moved this to Backlog in 2024.10 🎃 Sep 12, 2024
@cherman2 cherman2 removed this from 2024.10 🎃 Oct 24, 2024
@github-project-automation github-project-automation bot moved this to Backlog in 2025.4 🌻 Oct 24, 2024
@colinvwood colinvwood moved this from Backlog to In Development in 2025.4 🌻 Dec 13, 2024
@colinvwood colinvwood linked a pull request Dec 13, 2024 that will close this issue
Open
@colinvwood colinvwood moved this from In Development to Needs Review in 2025.4 🌻 Dec 13, 2024
@colinvwood colinvwood linked a pull request Dec 13, 2024 that will close this issue
BUG: make 7 number summary count base position starting from 1 #167
Open
@lizgehret lizgehret removed this from 2025.4 🌻 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinvwood colinvwood

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: make 7 number summary count base position starting from 1 colinvwood/q2-demux
3 participants
@gregcaporaso @thermokarst @colinvwood