Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119538: Add missing expat build dependencies #119647

Merged
merged 1 commit into from
May 28, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 28, 2024

xmltok_impl.c and xmltok_ns.c are included in xmltok.c by the C
pre-processor.

xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
@erlend-aasland
Copy link
Contributor Author

Touching any of the header files or included C files will trigger a rebuild of pyexpat.o and _elementtree.o.

Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@erlend-aasland erlend-aasland merged commit 606be66 into python:main May 28, 2024
37 checks passed
@erlend-aasland erlend-aasland deleted the expat-missing-deps branch May 28, 2024 20:05
@miss-islington-app
Copy link

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2024
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 28, 2024
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2024

GH-119685 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 28, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 28, 2024

GH-119686 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 28, 2024
@erlend-aasland
Copy link
Contributor Author

Thanks, Ned 🚂

erlend-aasland added a commit that referenced this pull request May 28, 2024
…119686)

xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.

(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request May 28, 2024
…119685)

xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.

(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants