Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes missing dependencies in Makefile #119538

Open
Meiye-lj opened this issue May 25, 2024 · 3 comments
Open

Fixes missing dependencies in Makefile #119538

Meiye-lj opened this issue May 25, 2024 · 3 comments
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@Meiye-lj
Copy link

Meiye-lj commented May 25, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

This Makefile fixes an issue in the cpython. Specifically, previously, any modifications of files like Modules/expat/*.c would not trigger a rebuild of Modules/expat/xmltok.o
Makefile_fixed.zip
. The Makefile fixes this by including them as additional dependencies.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@Meiye-lj Meiye-lj added the type-bug An unexpected behavior, bug, or error label May 25, 2024
@Eclips4 Eclips4 added the build The build process and cross-build label May 25, 2024
@ned-deily
Copy link
Member

Thank you for reporting the issue. Makefile is a file generated from Makefile.pre.in by running the configure script and thus any changes to the Python source code would need to be against Makefile.pre.in. Moreover, submitting any changes as the entire modified file especially one wrapped as a .zip file is difficult to review. Please follow our workflow guidelines in the Python Developer's Guide and open a pull request on GitHub with your proposed changes to Makefile.pre.in and reference this issue. Thanks!

@hugovk hugovk changed the title Fixes missing dependences in Makefile Fixes missing dependencies in Makefile May 26, 2024
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 28, 2024
@erlend-aasland
pythongh-119538: Add missing expat build dependencies
919face 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
@bedevere-app bedevere-app bot mentioned this issue May 28, 2024
Merged
erlend-aasland added a commit that referenced this issue May 28, 2024
@erlend-aasland
gh-119538: Add missing expat build dependencies (#119647)
606be66 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 28, 2024
@erlend-aasland @miss-islington
pythongh-119538: Add missing expat build dependencies (pythonGH-119647)
6c3eee7 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 28, 2024
@erlend-aasland @miss-islington
pythongh-119538: Add missing expat build dependencies (pythonGH-119647)
add3ed0 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
This was referenced May 28, 2024
Merged
Merged
erlend-aasland added a commit that referenced this issue May 28, 2024
@miss-islington @erlend-aasland
[3.12] gh-119538: Add missing expat build dependencies (GH-119647) (#…
46a37a1 
…119686)

xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.

(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
erlend-aasland added a commit that referenced this issue May 28, 2024
@miss-islington @erlend-aasland
[3.13] gh-119538: Add missing expat build dependencies (GH-119647) (#…
ef9fd10 
…119685)

xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.

(cherry picked from commit 606be66)

Co-authored-by: Erlend E. Aasland <[email protected]>
@ned-deily
Copy link
Member

With @erlend-aasland's PRs merged, I think we should be done with this issue. Thanks for calling it to our attention!

noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@erlend-aasland @noahbkim
pythongh-119538: Add missing expat build dependencies (python#119647)
bc0f8ca 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@erlend-aasland @estyxx
pythongh-119538: Add missing expat build dependencies (python#119647)
98ccc7e 
xmltok_impl.c and xmltok_ns.c are _included_ in xmltok.c by the C
pre-processor.
@Meiye-lj Meiye-lj mentioned this issue Oct 14, 2024
Closed
@erlend-aasland
Copy link
Contributor

Re-opening, since there are more missing dependencies.

@Meiye-lj Meiye-lj mentioned this issue Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ned-deily @erlend-aasland @Meiye-lj @Eclips4