Fix typing

[youtux]

Fix many mypy issues.
Notably, I replace private attributes like __scenario__, __scenario_report__, etc. with registries (WeakKeyDictionary). E.g.

# Old way

# setting value
scenario_wrapper.__scenario__ = scenario

# getting value
scenario = getattr(obj, "__scenario__", None)


# New way
# setting value
scenario_wrapper_template_registry[scenario_wrapper] = scenario

# getting value
scenario = scenario_wrapper_template_registry.get(scenario_wrapper)

Other changes:

• Replaced usages of Any with a more specific type if possible, otherwise object. Any causes the type checker to completely forego the type checking. Using object is a better way.

[codecov]

Codecov Report

Attention: Patch coverage is 94.25837% with 12 lines in your changes missing coverage. Please review.

Project coverage is 96.01%. Comparing base (6cdd340) to head (f4413e5).
Report is 29 commits behind head on master.

Files with missing lines	Patch %	Lines
src/pytest_bdd/cucumber_json.py	93.10%	3 Missing and 1 partial ⚠️
src/pytest_bdd/generation.py	57.14%	1 Missing and 2 partials ⚠️
tests/feature/test_report.py	81.25%	3 Missing ⚠️
src/pytest_bdd/utils.py	87.50%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   96.08%   96.01%   -0.08%     
==========================================
  Files          55       55              
  Lines        2250     2359     +109     
  Branches      246      250       +4     
==========================================
+ Hits         2162     2265     +103     
- Misses         53       56       +3     
- Partials       35       38       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jsa34]

@youtux I think mypy is happy now since we merged #698 ? If it is, perhaps we can close this?

[youtux]

Well, mypy is happy only because we put a lot of #type: ignore, ideally we wouldn't need those

[jsa34]

Good point - so the focus of this would be to eliminate those where possible :)

Copilot reviewed 5 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (9)

• CHANGES.rst: Language not supported
• src/pytest_bdd/steps.py: Evaluated as low risk
• src/pytest_bdd/cucumber_json.py: Evaluated as low risk
• src/pytest_bdd/feature.py: Evaluated as low risk
• src/pytest_bdd/compat.py: Evaluated as low risk
• tests/feature/test_report.py: Evaluated as low risk
• src/pytest_bdd/generation.py: Evaluated as low risk
• src/pytest_bdd/parser.py: Evaluated as low risk
• src/pytest_bdd/plugin.py: Evaluated as low risk

Comments skipped due to low confidence (4)

src/pytest_bdd/utils.py:99

• The default parameter should be typed as V | T | None to match the return type and avoid confusion.

def registry_get_safe(registry: WeakKeyDictionary[K, V], key: object, default: T | None = None) -> T | V | None:

src/pytest_bdd/scenario.py:289

• The type annotation for the decorator function is incorrect. It should be updated to match the new signature.

) -> Callable[[Callable[P, T]], Callable[P, T]]:

src/pytest_bdd/scenario.py:471

• [nitpick] The variable name 's' within the generator expression is not descriptive. It should be renamed to something more meaningful.

if (s := registry_get_safe(scenario_wrapper_template_registry, attr)) is not None

src/pytest_bdd/gherkin_terminal_reporter.py:77

• Ensure that scenario is not None before accessing its attributes to prevent potential AttributeError.

if self.verbosity <= 0 or scenario is None: