-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix call to pytest.mark.usefixtures without arguments #746
Conversation
This will raise a warning in an upcoming change in pytest
I think we need to either introduce a sort of "ScenarioFunction" protocol for mypy to be happy and expect scenario, or some short term ignoring of the mypy error, unless I am missing something, @youtux ? |
It's not quite clear to me how this change leads to mypy suddenly seeing the type of def (request: _pytest.fixtures.FixtureRequest, _pytest_bdd_example: builtins.dict[builtins.str, builtins.str]) -> Any Given the decorator is typed, this should already have been the case before I believe? As this isn't really related to this PR and we do a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 55 55
Lines 2199 2200 +1
Branches 242 242
=======================================
+ Hits 2110 2111 +1
Misses 54 54
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Actually I wanted to fix that in a different way. I started the work in #658, but never got to finish it... |
Ah, yes! I remember this now! |
This will raise a warning in an upcoming change in pytest.