Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic Rules for Bool Gauge SLOs #849

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Generic Rules for Bool Gauge SLOs #849

merged 2 commits into from
Aug 16, 2023

Commits on Aug 9, 2023

  1. Generic Rules for Bool Gauge SLOs 

    When trying to define a bool_gauge SLO with generic rules enabled, the resulting prometheus rule CRD is invalid as the generic rule group is empty.

This adds support for generic rules for bool gauges SLOs.

It also changes the definition of bool_gauge SLO a bit, by making grouping optional (in line with the rest of the SLOs definitions).
    Adrien Bestel committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    d3c20a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Revert adding success metric and matcher in the ruler logic

    Adrien Bestel committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    627aa2f View commit details
    Browse the repository at this point in the history