Generic Rules for Bool Gauge SLOs #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to define a bool_gauge SLO with generic rules enabled, the resulting prometheus rule CRD is invalid as the generic rule group is empty. This adds support for generic rules for bool gauges SLOs. It also changes the definition of bool_gauge SLO a bit, by making grouping optional (in line with the rest of the SLOs definitions).
metalmatze
reviewed
Aug 11, 2023
slo/promql.go
Outdated
Comment on lines
557
to
558
| } else if n.Name == "successMetric" { | ||
| n.Name = r.successMetric |
There was a problem hiding this comment.
So far it worked quite well to actually reuse the errorMetric for the other way around case of a successMetric too. It's probably possible here too. I get that naming the metric and matchers error isn't ideal in this case.
There was a problem hiding this comment.
Alright, I will revert this. I got a bit confused while doing this, but it's mostly because I'm not really familiar with Go overall.
There was a problem hiding this comment.
The naming is definitely not clean. The error should be named something else. It's really just the compare metric we compare against the total. 🤷♂️ Maybe that might be a good internal name at some point: compare.
metalmatze
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to define a bool_gauge SLO with generic rules enabled, the resulting prometheus rule CRD is invalid as the generic rule group is empty.
This adds support for generic rules for bool gauges SLOs.
It also changes the definition of bool_gauge SLO a bit, by making grouping optional (in line with the rest of the SLOs definitions).