Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link sBG Notebook in README and Index #1265

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

ColtAllen
Copy link
Collaborator

@ColtAllen ColtAllen commented Dec 13, 2024

Description

Adding links to the README and index pages for the ShiftedBetaGeoModelInidividual notebook. I also removed a line mentioning lifetimes from the README. I felt it was no longer pertinent because that library is now archived, and referenced extensively elsewhere in the documentation besides.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1265.org.readthedocs.build/en/1265/

@ColtAllen ColtAllen added docs Improvements or additions to documentation CLV labels Dec 13, 2024
@ColtAllen ColtAllen added this to the 0.11.0 milestone Dec 13, 2024
@ColtAllen ColtAllen requested a review from wd60622 December 13, 2024 00:25
@ColtAllen ColtAllen self-assigned this Dec 13, 2024
@ColtAllen ColtAllen changed the title Add sBG Notebook Link to README and Index Link sBG Notebook in README and Index Dec 13, 2024
@ColtAllen
Copy link
Collaborator Author

The Docs build failed due to a computational timeout 🤔

Copy link
Contributor

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wd60622 wd60622 merged commit cca56b4 into pymc-labs:main Dec 13, 2024
6 of 7 checks passed
@ColtAllen ColtAllen deleted the docs_shifted_bg branch December 15, 2024 02:54
aseyboldt pushed a commit to aseyboldt/pymc-marketing that referenced this pull request Dec 20, 2024
* Add sBG link to README

* Add sBG link to index

---------

Co-authored-by: Will Dean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link sBG notebook in the README
2 participants