Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log generated manifest if converted from legacy or integrated manifest type #677

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Log generated manifest if converted from legacy or integrated manifest type #677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3083ac
Show converted manifest
thomashoneyman Nov 28, 2023
a228266
Merge branch 'master' into trh/show-manifest
f-f Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions app/src/App/API.purs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,12 @@ publish source payload = do
]
Right manifest -> do
Log.debug "Successfully converted a spago.yaml into a purs.json manifest"
Comment.comment $ Array.fold
[ "Converted your spago.yaml into a purs.json manifest to use for publishing:\n"
, "```json"
, printJson Manifest.codec manifest
, "```"
]
pure manifest
else do
Comment.comment $ "Package source does not have a purs.json file. Creating one from your bower.json and/or spago.dhall files..."
Expand All @@ -457,10 +463,14 @@ publish source payload = do
Right legacyManifest -> do
Log.debug $ "Successfully produced a legacy manifest from the package source."
let manifest = Legacy.Manifest.toManifest payload.name version existingMetadata.location legacyManifest
Comment.comment $ Array.fold
[ "Converted your legacy manifest(s) into a purs.json manifest to use for publishing:\n"
, "```json"
, printJson Manifest.codec manifest
, "```"
]
pure manifest

Comment.comment "Verifying package..."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we're well underway in verification so I feel like it's not particularly helpful. I can put it back if we need it.


-- We trust the manifest for any changes to the 'owners' field, but for all
-- other fields we trust the registry metadata.
let metadata = existingMetadata { owners = manifest.owners }
Expand Down
Loading