Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log generated manifest if converted from legacy or integrated manifest type #677

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

thomashoneyman
Copy link
Member

Fixes #666. If we did not use the manifest in your source code directly (e.g. we converted a spago.yaml, spago.dhall, bower.json, etc. to a purs.json) then we explicitly show it to you before continuing. Since any errors wrt dependencies will be based on the generated purs.json file this helps narrow down any issues.

pure manifest

Comment.comment "Verifying package..."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we're well underway in verification so I feel like it's not particularly helpful. I can put it back if we need it.

Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@f-f f-f merged commit c7c9a3a into master Nov 29, 2023
15 checks passed
@f-f f-f deleted the trh/show-manifest branch November 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show generated manifest in logs when converting from legacy
2 participants