Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up license names + add more licenses and disambiguations #1

Merged
merged 7 commits into from
Nov 15, 2021

Conversation

gardenappl
Copy link

@gardenappl gardenappl commented Jan 4, 2021

(This is built on your latest commit but I'm not sure if I should open this PR here or on the upstream repo)

This PR introduces better handling of license name variants via the clean_license_name function. It takes a license name and:

  • removes the "custom:" prefix
  • turns it into lowercase
  • removes whitespace, commas, quotes, dashes and underscores

This means that, for example, "cc-by-sa 3.0" and "custom:CCBYSA3.0" are treated as the same license. The --list-licenses option prints the most popular variant.

I've also spent some time adding more licenses and packages into the "unambiguous" db.

@psvenk
Copy link
Owner

psvenk commented Nov 15, 2021

Thank you for the pull request! Sorry for the late response; for some reason, I did not get a notification email from GitHub about this — maybe this is because the PR was opened on a fork.

In any case, this looks good to me, and I'm happy that you took the initiative to do this work, opened orospakr#24, and created the new AUR package. Thank you again; I hope that our changes get upstreamed.

@psvenk psvenk merged commit 39b1041 into psvenk:expand Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants