Handle license variations, add more free licenses and disambiguate packages #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardenappl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of #23 and psvenk#1
TL;DR:
clean_license_namewhich turns license name to lowercase, removes whitespace, quotes, dashes, underscores, and the "custom:" prefix. This means that, for example,BSD-3andcustom:bsd3are now considered to be the same license.lib32-<pkgname>then vrms-arch will look at<pkgname>in the unambiguous db.This greatly reduces the number of false positives and "ambiguous packages".
I maintain an AUR package for my branch over at vrms-arch-git, but I will remove that package is this PR is accepted.