Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify release package #1337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

israpps
Copy link
Member

@israpps israpps commented Oct 9, 2024

lots of people not used to download from github ask wich file to download lots of times.

We upload the sime file twice in all cases. reduce that. only leave the main package duplicated. so the release version is clearly visible

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

@@ -198,9 +198,6 @@ jobs:
automatic_release_tag: "latest"
title: "${{ steps.version.outputs.version }}"
files: |
OPNPS2LD-${{ env.OPL_VERSION }}.7z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id rather keep that for pre-release too. I remember that this was done specially for your scripts that were not able to correctly parse OPNPS2LD-${{ env.OPL_VERSION }}.7z naming

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was intended for direct download links

But duplicating the release assets only confuses people.

And the version number is clearly visible on the heading of the release card

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But after downloading you will loose that info. If you will have tons of OPNPS2LD.7z archives its a mess to understand which one is correct. I agree that packages should be reduced, but I am against the idea to keep commit-less naming. The only reason to keep short version of archive names, is your scripts, so I advice to change scripts to be able to parse more complex naming.

lots of people not used to download from github ask wich file to download lots of times.

We upload the sime file twice in all cases.

as for tagged releases. only leave explicitly tagged files since these tags are not generated again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants