feat: Minimal in-browser compatibility for the crate #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the associated type `Params` of the `CircomFCircuit` to use the newly created `PathOrBin` type. This allows the user of the lib to directly send the binary of the files already read or instead, provide a path to it and let `sonobe` do the work. With this, Circom should be already usable from the browser if we allow JS to take care of reading the `.wasm` and `.r1cs` files.
|
Submitted 3e2f8fc Will work on the top of the rev for the time being. But not merge until we have it all working and merged. |
This commit temporarilly stands on top of dmpierre/arkworks_backend#1 referenced as `rev`. This changes the associated type `Params` of the `CircomFCircuit` to use the newly created `PathOrBin` type. This allows the user of the lib to directly send the binary of the files already read or instead, provide a path to it and let `sonobe` do the work. With this, Noir should be already usable from the browser if we allow JS to take care of reading the `circuit.json` files
|
This is awaiting feedback from @czhang2718 and @janabel to see if with this is feasible and decently OK to use the crate compiled to WASM from the browser. |
CPerezz
requested review from
dmpierre and
arnaucube
and removed request for
dmpierre
|
Got confirmation 0XPARC team that WASM is working. So this is good to go! |
dmpierre
approved these changes
Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the associated type
Paramsof theXXXFCircuitto usethe newly created
PathOrBintype.This allows the user of the lib to directly send the binary of the files
already read or instead, provide a path to it and let
sonobedo thework.
With this, Circom and Noir frontends should be already usable from the browser if we allow
JS to take care of reading the
.wasmand.r1csfiles.This currently depends on: