Nova parameters & decider parameters and proofs serialization #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I needed to modify the import of your |
arnaucube
force-pushed
the
nova-decider-serialization
branch
from
ee47397
to
fae1be8
Compare
…_params and public inputs
arnaucube
force-pushed
the
nova-decider-serialization
branch
from
fae1be8
to
b036124
Compare
arnaucube
force-pushed
the
nova-decider-serialization
branch
from
dce7646
to
cbf02ec
Compare
arnaucube
changed the title
|
This PR is now ready for review. |
CPerezz
requested changes
Sep 6, 2024
arnaucube
force-pushed
the
nova-decider-serialization
branch
from
cbf02ec
to
0e400e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds serialization for
Add also tests for it, which serve as examples of usage.
The idea is that with this PR, the full flow with Nova can be done with Prover's getting the serialized trusted setup parameters, and the Verifier getting the serialized proofs, inputs, and parameters, like they were from different instances/machines. An example of serializing and deserializing & verifying the proof (from the deserialized data) can be found at folding/nova/decider_eth.rs#L421 .
resolves #153