Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

468 add gripper parameter in goto posture #469

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

ClaireHzl
Copy link
Collaborator

add with_gripper parameter, to choose either the grippers open or stay the same when there is a goto_posture. Default to False, so the grippers keep the same opening.

@ClaireHzl ClaireHzl linked an issue Jan 8, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 8, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3061 2063 67% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/reachy2_sdk/parts/arm.py 30% 🟢
src/reachy2_sdk/reachy_sdk.py 36% 🟢
tests/units/online/test_advanced_goto_functions.py 100% 🟢
tests/units/online/test_basic_movements.py 100% 🟢
TOTAL 66% 🟢

updated for commit: 0d14eb0 by action🐍

Copy link
Contributor

@FabienDanieau FabienDanieau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Tested with Fake.
I have just added some suggestions

src/reachy2_sdk/parts/arm.py Outdated Show resolved Hide resolved
src/reachy2_sdk/parts/arm.py Outdated Show resolved Hide resolved
@ClaireHzl ClaireHzl merged commit b6a29a1 into develop Jan 8, 2025
8 checks passed
@ClaireHzl ClaireHzl deleted the 468-add-gripper-parameter-in-goto_posture branch January 8, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add gripper parameter in goto_posture
2 participants