Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

433 add rotate for head #434

Merged
merged 9 commits into from
Oct 24, 2024
Merged

433 add rotate for head #434

merged 9 commits into from
Oct 24, 2024

Conversation

ClaireHzl
Copy link
Collaborator

Rotate_by for the head, with frame "robot" and "head"

Copy link

github-actions bot commented Oct 21, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
989 904 91% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
tests/units/offline/test_utils.py 100% 🟢
tests/units/online/test_advanced_goto_functions.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 4448755 by action🐍

src/reachy2_sdk/parts/head.py Outdated Show resolved Hide resolved
src/reachy2_sdk/parts/head.py Outdated Show resolved Hide resolved
@ClaireHzl ClaireHzl requested a review from glannuzel October 22, 2024 14:37
@@ -293,6 +293,33 @@ def get_pose_matrix(position: List[float], rotation: List[float], degrees: bool
return pose


def quaternion_from_euler(roll: float, pitch: float, yaw: float, degrees: bool = True) -> Quaternion:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offline tests needed sorry :)

Copy link
Contributor

@FabienDanieau FabienDanieau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I would fix a test before merging though

src/reachy2_sdk/parts/head.py Show resolved Hide resolved
tests/units/offline/test_utils.py Outdated Show resolved Hide resolved
@ClaireHzl ClaireHzl merged commit cb1f721 into develop Oct 24, 2024
8 checks passed
@ClaireHzl ClaireHzl deleted the 433-add_rotate_for_head branch October 24, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants