Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to TypeErrors #431

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Switch to TypeErrors #431

merged 5 commits into from
Oct 24, 2024

Conversation

ClaireHzl
Copy link
Collaborator

Switch from ValueError to TypeError when needed, and correction of some docstrings

@ClaireHzl ClaireHzl linked an issue Oct 16, 2024 that may be closed by this pull request
Orbita ValueError should be TypeError #387
Closed
@ClaireHzl ClaireHzl changed the title Correction of TypeErrors Switch to TypeErrors Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
986 901 91% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
tests/units/offline/test_arm.py 100% 🟢
tests/units/offline/test_head.py 100% 🟢
tests/units/offline/test_orbita2d.py 100% 🟢
tests/units/offline/test_orbita3d.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 7fe6d86 by action🐍

glannuzel
glannuzel requested changes Oct 22, 2024
View reviewed changes
src/reachy2_sdk/utils/utils.py Show resolved Hide resolved
src/reachy2_sdk/parts/arm.py Outdated Show resolved Hide resolved
src/reachy2_sdk/parts/arm.py Outdated Show resolved Hide resolved
src/reachy2_sdk/parts/head.py Outdated Show resolved Hide resolved
@ClaireHzl
Copy link
Collaborator Author

ClaireHzl commented Oct 22, 2024 •
edited
Loading

I added a function _check_goto_parameters for the GoToBased_Parts, to do the checks (because the goto functions were too complex otherwise)

@ClaireHzl ClaireHzl requested a review from glannuzel October 22, 2024 10:13
FabienDanieau
FabienDanieau requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@FabienDanieau FabienDanieau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add unit tests!

src/reachy2_sdk/parts/arm.py Show resolved Hide resolved
src/reachy2_sdk/parts/head.py Show resolved Hide resolved
FabienDanieau
FabienDanieau approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@FabienDanieau FabienDanieau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that's perfect!

@ClaireHzl ClaireHzl merged commit d97a57f into develop Oct 24, 2024
8 checks passed
@ClaireHzl ClaireHzl deleted the 387-orbita-valueerror-should-be-typeerror branch October 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glannuzel glannuzel glannuzel approved these changes

@FabienDanieau FabienDanieau FabienDanieau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Orbita ValueError should be TypeError
3 participants
@ClaireHzl @FabienDanieau @glannuzel