Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 19-19 raised messaged fix #1560

Closed
wants to merge 4 commits into from
Closed

Rule 19-19 raised messaged fix #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a828ca
Addressed issue in 19-19 where if the W/CFM would pass if it was belo…
Nov 19, 2024
21752cd
Merge branch 'RT/JG/undetermined_text' into RT/JG/19_19_fix
Nov 20, 2024
f79e683
Merge branch 'RT/JG/undetermined_text' into RT/JG/19_19_fix
Dec 11, 2024
01c6618
Increased flow rate in 19-19e to ensure it fails conservatively (was …
Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rct229/rulesets/ashrae9012019/section19/section19rule19.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,11 @@ def get_manual_check_required_msg(self, context, calc_vals=None, data=None):
more_than_one_supply_fan_b = calc_vals["more_than_one_supply_fan_b"]

if more_than_one_supply_fan_b:
UNDERMINED_MSG = f"{hvac_id_b} has more than one supply fan associated with the HVAC system in the baseline and therefore this check could not be conducted for this HVAC sytem. Conduct manual check for compliance with G3.1.2.9."
UNDETERMINED_MSG = f"{hvac_id_b} has more than one supply fan associated with the HVAC system in the baseline and therefore this check could not be conducted for this HVAC sytem. Conduct manual check for compliance with G3.1.2.9."
else:
UNDERMINED_MSG = f"{hvac_id_b} has zone(s) with non-mechanical cooling in the proposed design, conduct a manual check that the baseline building design includes a fan power allowance of <insert IP or SI version as applicable Pfan = CFMnmc × 0.054, where, CFMnmc = the baseline non-mechanical cooling fan airflow, cfm for the non-mechanical cooling fan in additional to the 0.3 W/CFM allowance for the HVAC system>."
UNDETERMINED_MSG = f"{hvac_id_b} has zone(s) with non-mechanical cooling in the proposed design, conduct a manual check that the baseline building design includes a fan power allowance of <insert IP or SI version as applicable Pfan = CFMnmc × 0.054, where, CFMnmc = the baseline non-mechanical cooling fan airflow, cfm for the non-mechanical cooling fan in additional to the 0.3 W/CFM allowance for the HVAC system>."

return UNDERMINED_MSG
return UNDETERMINED_MSG

def rule_check(self, context, calc_vals=None, data=None):
zones_served_by_hvac_has_non_mech_cooling_bool_p = calc_vals[
Expand All @@ -297,7 +297,7 @@ def rule_check(self, context, calc_vals=None, data=None):
fan_power_per_flow_b,
REQ_FAN_POWER_FLOW_RATIO,
)
) or (fan_power_per_flow_b < REQ_FAN_POWER_FLOW_RATIO)
)

def is_tolerance_fail(self, context, calc_vals=None, data=None):
zones_served_by_hvac_has_non_mech_cooling_bool_p = calc_vals[
Expand Down
Loading
Loading