Rule 19-19 raised messaged fix #1560
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w the expected value. Now it correctly fails for < 0.3 W/CFM as well, but correctly raises the appropiate message from get_fail_msg. 19-19b is for W/CFM > 0.3 and the new 19-19e is for W/CFM < 0.3
added 3 commits
November 20, 2024 10:08
…incorreclty passing due to precision comparison)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue in 19-19 where if the W/CFM would pass if it was below the expected value. Now it correctly fails for < 0.3 W/CFM as well, but correctly raises the appropriate message from get_fail_msg. 19-19b is for W/CFM > 0.3 and the new 19-19e is for W/CFM < 0.3