Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ORCiD branding #849

Merged
merged 2 commits into from
Jan 24, 2025
Merged

update ORCiD branding #849

merged 2 commits into from
Jan 24, 2025

Conversation

taslangraham
Copy link
Contributor

@taslangraham taslangraham commented Jan 21, 2025 •
edited
Loading

@taslangraham taslangraham marked this pull request as ready for review January 21, 2025 16:16
@taslangraham taslangraham mentioned this pull request Jan 21, 2025
Closed
ewhanson
ewhanson requested changes Jan 23, 2025
View reviewed changes
templates/frontend/objects/preprint_details.tpl Outdated
@@ -137,11 +137,13 @@
{/if}
{if $author->getData('orcid')}
<span class="orcid">
{if $author->getData('orcidAccessToken')}
{if $author->getData('orcidAccessToken') && $author->hasVerifiedOrcid()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check should just use hasVerifiedOrcid rather than both it and orcidAccessToken.

@taslangraham taslangraham merged commit 2fb33cf into pkp:main Jan 24, 2025
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewhanson ewhanson ewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taslangraham @ewhanson