Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider new ORCID guidelines for displaying not unauthenticated ORCID iDs #10792

Open
bozana opened this issue Jan 10, 2025 · 5 comments
Open
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Jan 10, 2025

The guideline for unauthenticated ORCID iDs seem to be new -- another ORCID icon should be used in that case. Currently we do not display any icon for unauthenticated ORCID iDs, so this needs to be changed.

@bozana bozana added this to the 3.5.0 LTS milestone Jan 10, 2025
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Jan 10, 2025
@taslangraham
Copy link
Contributor

@bozana just confirming if this the new guideline you are referring to.

@bozana
Copy link
Collaborator Author

bozana commented Jan 15, 2025

Yes, sorry that I forgot to insert the link to it.
Thanks @taslangraham!

@taslangraham taslangraham self-assigned this Jan 15, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 17, 2025
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 17, 2025
@taslangraham
Copy link
Contributor

taslangraham commented Jan 17, 2025

@ewhanson @bozana There are two public facing pages that I'm unsure about displaying the new icon for users with an unauthenticated ORCiD - the about/editorialMasthead page and on the article page? Do you think it we should display the unauthenticated icon for user's on these pages too?

Article page
Image

editorialMasthead page

Image

@bozana
Copy link
Collaborator Author

bozana commented Jan 19, 2025

Hi @taslangraham, for the masthead: we should only display authenticated ORCID IDs there.
I am not sure about the article view page, I would say we should consider it there, but maybe @Devika008 and @ewhanson could help?

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 20, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/ui-library that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/ojs that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/ops that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/omp that referenced this issue Jan 21, 2025
taslangraham added a commit to taslangraham/omp that referenced this issue Jan 21, 2025
@taslangraham
Copy link
Contributor

Ready for review @ewhanson

PRs
pkp-lib: #10829
ui-library: pkp/ui-library#490
ojs: pkp/ojs#4614
ops: pkp/ops#849
omp: pkp/omp#1815

taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
None yet
Development

No branches or pull requests

2 participants