Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1.33 controller #43

Draft
wants to merge 373 commits into
base: e1.33
Choose a base branch
from
Draft

E1.33 controller #43

wants to merge 373 commits into from

Conversation

peternewman
Copy link
Owner

Please don't actually start reviewing this @kripton , but if you fancy taking a look at it in due course, I was going to break it down a bit to reduce the overall changes of this and https://github.com/OpenLightingProject/ola/pull/1612/files .

Most of the commits add a new PDU each (across three files), do you think there's an optimal number of files/size of commit to split it into for review?

I'll need to cherry-pick to get them into master without just queuing them up behind the existing LLRP stuff, but they should work fine standalone functionally...

peternewman and others added 16 commits February 3, 2024 16:07
…-mk2-serial-id

Track Eurolite MK2 by actual serial number where available
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@peternewman
Copy link
Owner Author

Thanks for the other reviews @kripton!

I'm pleased to say I've now got a basic E1.33 controller working (currently independent of the main olad). I've not tidied and pushed up all the code yet.

In terms of trying to reduce this giant changeset, as mentioned, most of the commits add a new PDU each (across three files), do you think there's an optimal number of files/size of commit to split it into for review to keep it manageable? For example here's the BrokerClientEntryPDU set of three (the PDUs vary in complexity a bit, but they're mostly broadly the same):
https://github.com/peternewman/ola/blob/e1.33-controller/libs/acn/BrokerClientEntryPDU.h
https://github.com/peternewman/ola/blob/e1.33-controller/libs/acn/BrokerClientEntryPDU.cpp
https://github.com/peternewman/ola/blob/e1.33-controller/libs/acn/BrokerClientEntryPDUTest.cpp

I'll need to cherry-pick to get them into master without just queuing them up behind the existing LLRP stuff, but they should work fine standalone functionally...

peternewman and others added 11 commits February 26, 2024 22:31
…ng-latest

Ignore more minified files that might contain spelling false positives
Co-authored-by: Peter Newman <[email protected]>
…dependabot/github_actions/actions/upload-artifact-4+download-artifact-4

Bump actions/upload-artifact and actions/download-artifact from 3 to 4
…P-fix-gcovr-parse-bug

Workaround gcovr parse race condition bug
Add support for the IPv6 data type to the RDM messaging
peternewman and others added 30 commits April 14, 2024 20:52
(cherry picked from commit 3d752e7)
(cherry picked from commit 2c2fdc7)
(cherry picked from commit 44ad498)
(cherry picked from commit ed8d532)
(cherry picked from commit 2d5280c)
(cherry picked from commit 720bb24)
(cherry picked from commit bc81275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants