Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1.33 controller #1841

Draft
wants to merge 148 commits into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Member

@peternewman peternewman commented Mar 13, 2023

I realised you might not have got the @mention in my personal repo ( peternewman#43 ) so I'll stick it here too.

This PR would want to go in after #1612 as it's done on top of that.

Please don't actually start reviewing this @kripton , but if you fancy taking a look at it in due course, I was going to break it down a bit to reduce the overall changes of this and https://github.com/OpenLightingProject/ola/pull/1612/files .

Most of the commits add a new PDU each (across three files), do you think there's an optimal number of files/size of commit to split it into for review?

I'll need to cherry-pick to get them into master without just queuing them up behind the existing LLRP stuff, but they should work fine standalone functionally...

Still todo:

peternewman and others added 30 commits January 29, 2020 18:58
All there apart from flags should always be 0xF0 rather than 0x70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants