Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Emojis to Icons #70

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

atharva-kashyap
Copy link
Contributor

@atharva-kashyap atharva-kashyap commented Jul 5, 2023

Describe this pull request. Link to relevant GitHub issues, if any.

This pull request updates some of the emojis on the web interface. This is linked to Issue number #25. This is to have icons consistent across all devices.

Explain how this pull request was tested, including but not limited to the below checkmarks.

This pull request was tested by running and ensuring the functionality stayed consistent overall.


Before creating a pull request

  • Format React code with npm run format
  • [N/A ] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Thoroughly test your code's responsiveness by rendering it on different devices, browsers, etc.
  • [N/A because I did not change any workflows ] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@atharva-kashyap atharva-kashyap linked an issue Jul 5, 2023 that may be closed by this pull request
@atharva-kashyap atharva-kashyap changed the title Atharvak/emoji to icons Change Emojis to Icons Jul 5, 2023
@atharva-kashyap
Copy link
Contributor Author

Note: For crediting the icon creators, I have them somewhere else. I am not sure where I should add that in the codebase. Please let me know and I can add that as well!

@atharva-kashyap atharva-kashyap self-assigned this Jul 5, 2023
@amalnanavati
Copy link
Contributor

Credit to icon designers should go in https://github.com/personalrobotics/feeding_web_interface/blob/main/feedingwebapp/Acknowledgements.md

Often times, the website where you got the icons (e.g., The Noun Project) will have specific guidelines on how to attribute the creators. Follow those guidelines when wording the Acknowledgement statement(s).

Make sure the icons are open-source (commonly denoted by having a Creative Commons license)

@atharva-kashyap
Copy link
Contributor Author

@amalnanavati Thanks for the feedback! I have added the acknowledgments as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace all Emojis with a Icons/Images
2 participants