Merge main #1167
Merged
Merge main #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Date time data model
Co-authored-by: R. C. Howell <[email protected]>
Carries out streamlining of PartiQLPigVisitor proposed and discussed in PR #1144. In addition to visit() and visitOrNull() this also replaces visitNullableItems() and visitOrEmpty() -- essentially by their inlinings, which are then further simplified or concretized, making things more straightforward and even a tad more concise.
Now parsing the full assortment of node/edge label patterns: named label, disjunction, conjunction, negation, grouping, and wildcard.
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (d18eaac) but now fail: 0 Number failing in Base (d18eaac) but now pass: 0 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## pluggable-functions #1167 +/- ##
======================================================
Coverage ? 71.98%
Complexity ? 2333
======================================================
Files ? 228
Lines ? 17690
Branches ? 3241
======================================================
Hits ? 12735
Misses ? 3963
Partials ? 992
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Add pluggable functions tutorial and pull latest codes from main branch.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
YES
Any backward-incompatible changes? [YES/NO]
NO
Any new external dependencies? [YES/NO]
NO
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.