Shallow copy of npy_array_t #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! Yes! Yes! This makes sense! Let me just test out a few things. Should we also have some tests in the CI for for this feature? |
|
Yes! Please add a run of the 'copying` example in the .github/workflows/make_and_examples.yaml file. |
|
I added the example to CI, including another example that reads the created file and checks for correctnes of the data. |
|
Merging this! Thanks a lot Lennart! I will even close #14 with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #30, I implemented my suggestion of having a private data member that is NULL in case an npy_array_t* object doesn't own its data. If you think the interface is getting too cluttered by this I would be very happy to discuss other approaches.