Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange 'npy_array_list_free()' #14

Closed
oysteijo opened this issue Feb 15, 2020 · 2 comments
Closed

Strange 'npy_array_list_free()' #14

oysteijo opened this issue Feb 15, 2020 · 2 comments

Comments

@oysteijo
Copy link
Owner

Freeing a list does a lot of things. It frees everything
The array, the array->data, the filename, and the element itself.

In some cases the caller is not the owner of all this data, and then the caller will have to run their own solutions for freeing the lists. This requiers knowledge of the implementation etc. Is this code smell?

@oysteijo
Copy link
Owner Author

oysteijo commented Feb 7, 2022

Maybe the libzip interface is just as convenient as the clumsy linked list structure? Maybe using npy_array_list should be discouraged? Or maybe not?

@oysteijo
Copy link
Owner Author

Closed by #30 and #31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant