Fix/pci rancher version fix sort tapc 2629 #15272
Open
+113
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppprevost
requested review from
qpavy,
aboungnaseng-ovhcloud,
sidlynx,
kqesar,
ghyenne and
mhelhali-soufien
SimonChaumet
reviewed
Feb 3, 2025
| }; | ||
|
|
||
| export const sortVersions = (versions: RancherVersion[]): RancherVersion[] => { | ||
| return [...versions].sort((a, b) => { |
There was a problem hiding this comment.
Copy should be handled by caller. In your specific case since there is a filter before you do not need to copy the array
| @@ -26,6 +26,29 @@ export const getCurrentVersionInfo = ( | |||
| return getVersionInfoByName(currentVersion, versions); | |||
| }; | |||
|
|
|||
| export const compareVersions = (v1: string, v2: string): number => { | |||
There was a problem hiding this comment.
I think we should use https://www.npmjs.com/package/semver instead
Comment on lines
64
to
66
| if (sortedVersions.length === 0) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This case is already handled line 72
tibs245
reviewed
Feb 3, 2025
| return sortVersions(availableVersions)[availableVersions.length - 1]; | ||
| } | ||
| return null; | ||
| }, [versions, selectedVersion]); |
There was a problem hiding this comment.
Why : selectedVersion is in this array ?
There was a problem hiding this comment.
it's a mistake, a previous dependecy i forget to delete
SimonChaumet
previously approved these changes
Feb 3, 2025
tibs245
previously approved these changes
Feb 4, 2025
SimonChaumet
approved these changes
Feb 4, 2025
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
fix/pci-rancher_version-fix-sort_tapc-2629
branch
from
dd9cd75 to
92012b8
Compare
|
tibs245
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related