fix(pci.rancher): update order version

ref: TAPC-2629 Signed-off-by: Pierre-Philippe <[email protected]>
ovh · Feb 4, 2025 · dd9cd75 · dd9cd75
1 parent c83a015
commit dd9cd75
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/.../apps/pci-rancher/src/components/layout-helpers/CreateRancher/CreateRancher.component.tsx b/.../apps/pci-rancher/src/components/layout-helpers/CreateRancher/CreateRancher.component.tsx
@@ -152,7 +152,7 @@ const CreateRancher: React.FC<CreateRancherProps> = ({
       (version) => version.status === 'AVAILABLE',
     );
     if (availableVersions?.length) {
-      return sortVersions(availableVersions)[availableVersions.length - 1];
+      return sortVersions(availableVersions, 'desc')[0];
     }
     return null;
   }, [versions]);
@@ -312,7 +312,7 @@ const CreateRancher: React.FC<CreateRancherProps> = ({
         </Block>
         <div className="flex my-5">
           {versions &&
-            sortVersions(versions).map((version) => (
+            sortVersions(versions, 'desc').map((version) => (
               <TileSection
                 key={version.name}
                 isActive={version.name === selectedVersion?.name}

diff --git a/packages/manager/apps/pci-rancher/src/utils/rancher.ts b/packages/manager/apps/pci-rancher/src/utils/rancher.ts
@@ -27,9 +27,12 @@ export const getCurrentVersionInfo = (
   return getVersionInfoByName(currentVersion, versions);
 };
 
-export const sortVersions = (versions: RancherVersion[]): RancherVersion[] => {
+export const sortVersions = (
+  versions: RancherVersion[],
+  order: 'asc' | 'desc' = 'asc',
+): RancherVersion[] => {
   return versions.sort((a, b) => {
-    return semver.compare(a.name, b.name);
+    return (order === 'asc' ? semver.compare : semver.rcompare)(a.name, b.name);
   });
 };