fix(mrc): dont render TileBlock optional label #15261
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tristanwagner
changed the title
tristanwagner
requested review from
darsene,
stif59100,
frenautvh and
seven-amid
tibs245
previously approved these changes
Feb 3, 2025
ghyenne
previously approved these changes
Feb 3, 2025
anooparveti
requested changes
Feb 3, 2025
Comment on lines
13
to
18
| <dl className="flex flex-col gap-1 m-0"> | ||
| <dt> | ||
| <OdsText preset={ODS_TEXT_PRESET.heading6}>{label}</OdsText> | ||
| </dt> | ||
| {label && ( | ||
| <dt> | ||
| <OdsText preset={ODS_TEXT_PRESET.heading6}>{label}</OdsText> | ||
| </dt> | ||
| )} | ||
| <dd className="m-0">{children}</dd> | ||
| </dl> |
There was a problem hiding this comment.
nitpick: By definition, dd tag provides the description for the preciding term dt.
If you have a requirement to not display dt, then imo, we have to think of adding modes for this where you display datalist/text/link.
There was a problem hiding this comment.
I updated as we said earlier, keeping the dt anyway but not rendering the OdsText since it is the part that cause the unwanted space
There was a problem hiding this comment.
For actions items, it will be better to not use dl/dt/dd, and render something specific. (probably a div with margin and children)
3 tasks
SimonChaumet
reviewed
Feb 3, 2025
...ages/manager-react-components/src/components/content/dashboard-tile/tile-block.component.tsx
Outdated
Show resolved
Hide resolved
ref: ISSUE-15260 Signed-off-by: Tristan WAGNER <[email protected]>
tristanwagner
force-pushed
the
fix/ISSUE-15260
branch
from
5c07643 to
1788ecb
Compare
|
anooparveti
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ISSUE-15260
developDescription
Related