Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manager-components]: <TileBlock /> label should not render if empty #15260

Open
3 tasks
tristanwagner opened this issue Feb 3, 2025 · 1 comment · May be fixed by #15261
Open
3 tasks

[manager-components]: <TileBlock /> label should not render if empty #15260

tristanwagner opened this issue Feb 3, 2025 · 1 comment · May be fixed by #15261
Labels
bug Something isn't working manager-components

Comments

@tristanwagner
Copy link
Contributor

On which entity, you would like to report a bug?

TileBlock

Description

Due to recent changes, right now the TileBlock label props is optional but it still renders if it is empty (at least on Firefox)

Steps to reproduce

Declare a <DashboardTile /> with some items without a label property

Image

We want to be able to not render the label element if it is empty

Image

Browser

No response

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

No response
@tristanwagner tristanwagner added bug Something isn't working manager-components labels Feb 3, 2025
@tristanwagner tristanwagner linked a pull request Feb 3, 2025 that will close this issue
Open
8 tasks
@tristanwagner tristanwagner linked a pull request Feb 3, 2025 that will close this issue
fix(mrc): dont render TileBlock optional label #15261
Open
8 tasks
@anooparveti
Copy link
Contributor

Added a comment - #15261 (comment). We will have to refine this @tristanwagner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working manager-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mrc): dont render TileBlock optional label ovh/manager
2 participants
@tristanwagner @anooparveti