Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract size optimization - remove unused royalty fetcher to reduce contract size #140

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Aug 14, 2023

No description provided.

@oveddan
Copy link
Collaborator Author

oveddan commented Aug 14, 2023

This was referenced Aug 14, 2023
@oveddan oveddan requested a review from iainnash August 14, 2023 22:59
@oveddan oveddan changed the title remove unused royalty fetcher to reduce contract size Contract size optimization - remove unused royalty fetcher to reduce contract size Aug 16, 2023
@oveddan oveddan changed the base branch from contract-size-ci to main August 17, 2023 03:51
Copy link
Collaborator

@iainnash iainnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we used this on the contract level but I now realized we removed it. Did you check the front-end usage?

Copy link
Collaborator Author

@oveddan oveddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattlenz are you using the read method supplyRoyaltyInfo anywhere in the frontend? I didn't see it anywhere when searching the repo

@oveddan oveddan removed the request for review from jgeary September 15, 2023 02:41
@iainnash
Copy link
Collaborator

@oveddan oveddan merged commit 5ca32b0 into main Sep 21, 2023
6 checks passed
iainnash pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants