-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
only include contract address in signature #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2023
Merged
Merged
Closed
Closed
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 14, 2023
oveddan
force-pushed
the
creator-attribution
branch
from
August 15, 2023 23:20
13185a7
to
85c8dc3
Compare
oveddan
force-pushed
the
sign-address-only
branch
from
August 15, 2023 23:20
e73a02a
to
34f9be8
Compare
…nformation to hash Since we now know that the erc1155 is the one that is validating the sig, we can know that the hash is equiv to the contract address
oveddan
force-pushed
the
creator-attribution
branch
from
August 16, 2023 01:18
85c8dc3
to
c0d3a2a
Compare
oveddan
force-pushed
the
sign-address-only
branch
from
August 16, 2023 01:18
34f9be8
to
388f60c
Compare
This was referenced Aug 16, 2023
Closed
Closed
Merged
Merged
This was referenced Sep 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.