-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Speed Sensor Documentation #269
Conversation
pi4micronaut-utils/src/docs/asciidoc/components/inputComponents/speedSensor.adoc
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an inconsistency between the YAML configuration and the circuit diagram. The circuit diagram points to GPIO 17, while the YAML configuration is pointing to GPIO 22. Please update either the diagram or the configuration to ensure they both reflect the correct GPIO pin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I like the detail in the assembly instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request provides thorough documentation for the speed sensor, including its capabilities, YAML configuration, circuit setup image, schematic diagram, and usage instructions. Everything is clear and well-structured
Fixes #264
Created documentation for our Speed Sensor. Including all necessary information to assist in someone wants to utilize a speed sensor in their project. Added speedSensor.adoc to house the circuit and schematic diagrams, as well as example testing, assembly information, and necessary components.