-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DC Motor documentation #268
DC Motor documentation #268
Conversation
…s, added troubleshooting info and a couple build instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "TODO: finish documentation here" under the Assembly Instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation aligns well with the project requirements, but please remove the "TODO: finish documentation here" note under the Assembly Instructions. From a product and code quality perspective, it's important to keep the code clean and avoid placeholder comments. Looking forward to the updates.
Todo:
Remove "TODO: finish documentation here" under the Assembly Instructions.
---- | ||
|
||
* `/enable` - Enables the motor. | ||
* `/disable` - Disables the motor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show how these could be run from command line.
…dule-for-pi4micronaut' into 263-document-dc-motor-control-module-for-pi4micronaut
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request successfully implements the DC motor control functionality, providing comprehensive documentation that includes component descriptions, YAML configuration, circuit setup images, and clear usage instructions. The detailed information will greatly assist users in controlling motor speed and direction effectively.
Resolved #263
Added motor.adoc file. Currently it includes info about API calls, YAML file, and a link to the example controller.