Consistently use projectType as the ID type for projects
#9680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
use-project-type
branch
from
831962e to
dd9079f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9680 +/- ##
=========================================
Coverage 68.07% 68.07%
+ Complexity 1285 1284 -1
=========================================
Files 249 249
Lines 8827 8827
Branches 918 918
=========================================
Hits 6009 6009
Misses 2432 2432
Partials 386 386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
use-project-type
branch
from
dd9079f to
3040b7c
Compare
sschuberth
force-pushed
the
use-project-type
branch
7 times, most recently
from
82cc92c to
6398547
Compare
"Go" (or "Golang") is the language, but "GoMod" is the project type (as well as the manager name). This is a fixup for 5d5ea5c. Signed-off-by: Sebastian Schuberth <[email protected]>
Do not use the `managerName` to create IDs for projects, even if in most cases the strings happen to match the respective `projectType`. This change may be breaking existing package configurations that refer to projects for which the type as part of the ID changed. Signed-off-by: Sebastian Schuberth <[email protected]>
If a manager would get renamed, the package type should stay the same. Signed-off-by: Sebastian Schuberth <[email protected]>
sschuberth
force-pushed
the
use-project-type
branch
from
6398547 to
d7f223f
Compare
mnonnenmacher
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.