fix(package-managers): Do not set the package type to the manager name

If a manager would get renamed, the package type should stay the same. Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Jan 17, 2025 · d7f223f · d7f223f
1 parent a5659de
commit d7f223f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/plugins/package-managers/bazel/src/main/kotlin/Bazel.kt b/plugins/package-managers/bazel/src/main/kotlin/Bazel.kt
@@ -434,7 +434,7 @@ class Bazel(
     private fun BazelModule.toPackageReference(archiveOverrides: Map<String, ArchiveOverride>): PackageReference =
         PackageReference(
             id = Identifier(
-                type = managerName,
+                type = "Bazel",
                 namespace = "",
                 name = key.substringBefore("@", ""),
                 version = key.substringAfter("@", "")

diff --git a/plugins/package-managers/carthage/src/main/kotlin/Carthage.kt b/plugins/package-managers/carthage/src/main/kotlin/Carthage.kt
@@ -183,7 +183,7 @@ class Carthage(
 
         return Package(
             id = Identifier(
-                type = managerName,
+                type = "Carthage",
                 namespace = vcsHost?.getUserOrOrganization(projectUrl).orEmpty(),
                 name = vcsHost?.getProject(projectUrl).orEmpty(),
                 version = revision
@@ -207,7 +207,7 @@ class Carthage(
 
         return Package(
             id = Identifier(
-                type = managerName,
+                type = "Carthage",
                 namespace = "",
                 name = fileUrl.substringAfterLast("/"),
                 version = revision
@@ -225,7 +225,7 @@ class Carthage(
     private fun createPackageFromBinarySpec(binarySpec: Map<String, String>, id: String, revision: String) =
         Package(
             id = Identifier(
-                type = managerName,
+                type = "Carthage",
                 namespace = "",
                 name = id.substringAfterLast("/").removeSuffix(".json"),
                 version = revision

diff --git a/plugins/package-managers/pub/src/main/kotlin/Pub.kt b/plugins/package-managers/pub/src/main/kotlin/Pub.kt
@@ -378,7 +378,7 @@ class Pub(
             if (pkgInfoFromLockfile == null || pkgInfoFromLockfile.source == "sdk") return@forEach
 
             val id = Identifier(
-                type = managerName,
+                type = "Pub",
                 namespace = "",
                 name = packageName,
                 version = pkgInfoFromLockfile.version.orEmpty()
@@ -629,7 +629,7 @@ class Pub(
                 }
 
                 val id = Identifier(
-                    type = managerName,
+                    type = "Pub",
                     namespace = "",
                     name = rawName,
                     version = version