-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nexus_demos
package
#49
base: luca/rmf_transporter
Are you sure you want to change the base?
Conversation
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Currently this branch uses
I'm a bit hesitant to build from source since it would add a good chunk of time to our CI. Edit: Note that this is not a blocker to the original PR so I will get to it regardless of what we decide here |
Signed-off-by: Aaron Chong <[email protected]>
I was planning to set up docker images for underlay workspaces (RMF and zenoh bridge), and rely on nightly builds to set up the images. Then in our CI we just use those images to continue nexus builds and tests, that should speed things up I prefer to stick to the current approach of using binaries as much as possible, and only use source builds if necessary. I'll open another PR targeting #42, when I'm done. Let me know what you think. |
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
Apart from merge conflicts / new configurations there was a floating table and robots that still bumped into the table once in a while, addressed that in b014493 |
Upstream PR open-rmf/rmf_traffic_editor#523 merged. I'm still a bit on the fence on whether to hack it on traffic editor or introduce an RMF partial source build, I'll defer it to the result of the docker experimentation |
…ze launch files from integration tests Signed-off-by: Aaron Chong <[email protected]>
…date readme Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
nexus_integration_tests
previously, into a new package, including all the bts and config files under theconfig
directory.world
file and navigation graphs directly into the package, with instructions in README on how to regenerate them. Building thenexus_demos
package will however still need the model downloading step, since the models are still added into.building.yaml
fromtraffic-editor
(unless we want to eyeball and add assets into the template world file instead)Testing
Things to consider (with subsequent PRs)
nexus_integration_tests
and intonexus_demos
to be made more reusable, so that the integration tests are dependent on the demos, not the other way around