Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mobile_phone_accessories.json with "La Casa de las Carcasas" #10214

Merged
merged 3 commits into from
Dec 14, 2024

Conversation

DnaX
Copy link
Contributor

@DnaX DnaX commented Dec 9, 2024

I added the new file for shop=mobile_phone_accessories and added "La Casa de las Carcasas" (present in Spain, Portugual, France and Italy).

@Cj-Malone
Copy link
Collaborator

Seems weird to add a tree for shop=mobile_phone_accessories when there is only 200 globally

@DnaX
Copy link
Contributor Author

DnaX commented Dec 9, 2024

The problem is that shop=mobile_phones it's crowded with all sort of mobile phone accessories stores that's not sell mobile_phones. The tag shop=mobile_phone_accessories it's quite new but needs to spead, even if it's not rendered with proper icon on iD or Carto tiles.

@Snowysauce Snowysauce added add brand Actionable - add a brand to the index new category Add support for a new kind of feature needs discussion Waiting for other contributors to voice their opinion labels Dec 10, 2024
@UKChris-osm
Copy link
Collaborator

Seems weird to add a tree for shop=mobile_phone_accessories when there is only 200 globally

Every tag has to start from somewhere, and I expect there are a lot of accessory shops tagged as mobile phone shops due to the lack of a more relevant tag.

Although this won't appear in iD until the new tag has been added to the ID Tagging Schema.

@UKChris-osm UKChris-osm self-requested a review December 14, 2024 11:28
@UKChris-osm
Copy link
Collaborator

You should be able to preview this now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index needs discussion Waiting for other contributors to voice their opinion new category Add support for a new kind of feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants