-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preset: shop=mobile_phone_accessories #1406
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
Are the wiki data items (AKA the "Info-i") ready as well? I don't see any reason to merge this other that the low usage. But given that this is already part of NSI (with overwrites any preset), I wonder if we actually need this now… |
Currently there is this item linked to "shop=mobile_phone_accessories": https://www.wikidata.org/wiki/Q6887188 |
I've just noticed that this new addition links to the generic shop OSM Wiki rather than a phone shop accessory one, and it seems mobile_phone_accessories doesn't have a data item attached to it. Is creating a data item a simple process? |
Yes, I think so. My workflow is…
Creating all those relations is a bit special but for iD we mostly need the name + description + right identifier as a tag. |
I've started with Q22720 |
Description, Motivation & Context
#1405 requests the addition of
shop=mobile_phone_accessories
to the tagging schema. The NSI has already had an entry added that could make use of this new tag: osmlab/name-suggestion-index#10214Perhaps the term used should be "accessories" though?
Currently:
With PR:
Related issues
closes #1405
Links and data
Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Tag%3Ashop%3Dmobile_phone_accessories
Relevant tag usage stats:
240 as of 2024-12-14 (low, but growing)
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.