Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset: shop=mobile_phone_accessories #1406

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

UKChris-osm
Copy link
Contributor

@UKChris-osm UKChris-osm commented Dec 14, 2024

Description, Motivation & Context

#1405 requests the addition of shop=mobile_phone_accessories to the tagging schema. The NSI has already had an entry added that could make use of this new tag: osmlab/name-suggestion-index#10214

Perhaps the term used should be "accessories" though?

Currently:
mobile-phone-1

With PR:
mobile-phone-2
mobile-phone-3
mobile-phone-4

Related issues

closes #1405

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag%3Ashop%3Dmobile_phone_accessories

Relevant tag usage stats:

240 as of 2024-12-14 (low, but growing)

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [x] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [x] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

Are the wiki data items (AKA the "Info-i") ready as well?


I don't see any reason to merge this other that the low usage. But given that this is already part of NSI (with overwrites any preset), I wonder if we actually need this now…

@DnaX
Copy link

DnaX commented Dec 19, 2024

Are the wiki data items (AKA the "Info-i") ready as well?

Currently there is this item linked to "shop=mobile_phone_accessories": https://www.wikidata.org/wiki/Q6887188

@UKChris-osm
Copy link
Contributor Author

Are the wiki data items (AKA the "Info-i") ready as well?

I've just noticed that this new addition links to the generic shop OSM Wiki rather than a phone shop accessory one, and it seems mobile_phone_accessories doesn't have a data item attached to it.

Is creating a data item a simple process?

@tordans
Copy link
Collaborator

tordans commented Dec 19, 2024

Is creating a data item a simple process?

Yes, I think so. My workflow is…

  1. take the link from
    [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
    , open https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i
  2. goto https://wiki.openstreetmap.org/wiki/Data_items#Item_creation_process
  3. follow the https://wiki.openstreetmap.org/wiki/Special:NewItem link
  4. I find it easiest to first look up a tag wiki data item via https://wiki.openstreetmap.org/w/index.php?search=&title=Special%3ASearch&profile=advanced&fulltext=1&ns120=1 (link from the same page in (2)) and follow the same pattern with the new one

Creating all those relations is a bit special but for iD we mostly need the name + description + right identifier as a tag.

@UKChris-osm
Copy link
Contributor Author

I've started with Q22720

@UKChris-osm
Copy link
Contributor Author

UKChris-osm commented Dec 21, 2024

The info-i seems to be working within the preview, however I've noticed that when using a brand Casetify, the text underneath simply reads Shop, rather than Mobile Phone Accessory Store.

tagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a preset for shop=mobile_phone_accessories
3 participants