Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-base: addressing this.vstack[0] is undefined. #7557

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Jan 10, 2025

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile
  • Tested on: x86_64 VM with OpenWrt 24.10.0-rc5 (r28304-6dacba30a7)
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: with a67d683, any attempt to Edit a network interface produces a yellow message TypeError: this.vstack[0] is undefined:
    Screenshot_2025-01-10_23-04-51
    I believe the reason is that .datatype cannot be an empty string. With this change the TypeError is gone.

@systemcrash systemcrash merged commit abaa26a into openwrt:master Jan 10, 2025
4 checks passed
@systemcrash
Copy link
Contributor

Good catch. That does look better. Thanks @adelton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants