luci-base: Enforce maximal firewall zone length in the Create / Assign scenario as well.

[adelton]

• This PR is not from my main or master branch 💩, but a separate branch ✅
• Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
• Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
• Incremented 🆙 any PKG_VERSION in the Makefile
• Tested on: local x86_64 VM with OpenWrt 23.05.5 (r24106-10cc5fcd00)
• ( Preferred ) Mention: @ the original code author for feedback
• ( Preferred ) Screenshot or mp4 of changes:
• ( Optional ) Closes luci-app-firewall OR luci-app-network: Can create firewall zone in interfaces of any length but firewall allows only 11 chars #7522
• ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
• Description: adding check for maximum firewall zone length also to the widget used in the Create / Assign scenario.

[systemcrash]

@dannil your approach was a bit different, right?

[systemcrash]

Merged. Thanks @adelton

[dannil]

@dannil your approach was a bit different, right?

I guess you're thinking of the kinda related #7289? Then yes since interfaces appends their protocol when persisted to UCI, and this combination of protocol + interface name needs to be validated together which isn't done today, but that problem shouldn't exist for firewall zones. The solution in this PR for this specific problem should definitely suffice.

[systemcrash]

The solution in this PR for this specific problem should definitely suffice.

Good. That's what I figured. Thanks for the check!

[jow-]

This length constraint should only apply to fw3, fw4 (nft) has no zone name length limit iirc.

[systemcrash]

@jow- OK. I'll add a fix to relax that.

See a67d683

[adelton]

@systemcrash Please see #7557 as a followup to a67d683.

[adelton]

This PR caused a regression #7563 and was reverted in 7046a1c.