Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation rules for cycleway=opposite #Part1 #1295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Jul 25, 2024

This solves the main issues described in #1271 to put the recently approved deprecation of the cycleway=opposite tagging into our deprecation rules.

  1. It updates the custom translations for the two opposite option to reflect the deprection.
  2. It adds the most common and simplest deprecation to to automatically updated
    This is the one with the most usage (46k + 4k) ATM (Usage stats)

I suggest we merge this separate of other possible deprecations. I will create a separate issue for those.

@tordans tordans requested a review from tyrasd July 25, 2024 04:49
Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator Author

tordans commented Jul 25, 2024

Testing

Query https://overpass-turbo.eu/s/1OIw

test 1

https://pr-1295--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w114097468&locale=en&map=19.01/52.48624/13.42682
image
image

==> All good

test2

https://pr-1295--ideditor-presets-preview.netlify.app/id/dist/#background=Berlin-2023&disable_features=boundaries&id=w5216567&locale=en&map=19.27/52.54829/13.19451

https://www.mapillary.com/app/user/tordans?lat=52.548182299999&lng=13.194176100002&z=17&mapStyle=Mapillary+light&pKey=785476499277461&focus=photo&x=0.492695052003444&y=0.5125723764267668&zoom=0

image image

==> all good; would be cycleway:both=no in this case, but that can be updated manually

test3

https://pr-1295--ideditor-presets-preview.netlify.app/id/dist/#background=Brandenburg-DOP20c&disable_features=boundaries&id=w10612191&locale=en&map=20.00/52.39148/13.09470&photo_overlay=mapillary
image

This case was a bit more interesting. It shows that many ways that use the opposite schema need to be checked more closely. In this case, the tagging was wrong and needed to be updated.

We found cases where oneway=yes is not the right update path because access tags are used instead. We assume, that oneway=yes is usually tagged already, so we don't need to add it to the replacement. However, the oneway:bicycle=no is used less often and also does less harm in case someone does apply the deprecation in cases where it should not be applied.
data/deprecated.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants